Repository navigation
feat(sanity): T4Dataset 1.0 sanity rules - #313
Merged
Merged
Conversation
jacoblambert
force-pushed
the
v1/sanity
branch
from
October 15, 2026 03:36
5b8948c to
2c6ec49
Compare
jacoblambert
force-pushed
the
v1/sanity-spec
branch
2 times, most recently
from
October 15, 2026 05:23
1c95ad0 to
e01012d
Compare
jacoblambert
force-pushed
the
v1/sanity
branch
2 times, most recently
from
October 15, 2026 05:40
04dfa9c to
14bf681
Compare
jacoblambert
force-pushed
the
v1/sanity-spec
branch
from
October 15, 2026 05:40
e01012d to
55a149c
Compare
jacoblambert
marked this pull request as ready for review
October 15, 2026 06:18
jacoblambert
force-pushed
the
v1/sanity
branch
from
October 15, 2026 08:26
14bf681 to
f5070ca
Compare
jacoblambert
force-pushed
the
v1/sanity-spec
branch
from
October 15, 2026 08:26
55a149c to
75414a6
Compare
jacoblambert
force-pushed
the
v1/sanity
branch
from
October 15, 2026 10:37
f5070ca to
f5ed9a6
Compare
jacoblambert
force-pushed
the
v1/sanity-spec
branch
2 times, most recently
from
October 21, 2026 01:31
d2ed161 to
f21f675
Compare
jacoblambert
force-pushed
the
v1/sanity
branch
from
October 21, 2026 01:31
f5ed9a6 to
6a7bfab
Compare
ktro2828
self-requested a review
October 21, 2026 05:29
jacoblambert
force-pushed
the
v1/sanity-spec
branch
from
October 22, 2026 09:55
f21f675 to
ab2563f
Compare
jacoblambert
force-pushed
the
v1/sanity
branch
from
October 22, 2026 09:56
6a7bfab to
f951085
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the 1.0 sanity rules from #311.
t4sanitynow checks the dataset version first. A dataset with amanifest.jsonis 1.0. It runs only the rules for that version.0.x datasets get the same 60 rules and the same results as before.
How it works
Each rule says which versions it applies to. The default is 0.x.
Rules that mean the same in both versions run on both. For example,
STR002(annotation/exists) andREF001(Scene.log_tokenpoints to aLog).Most new rules read records, not raw JSON. The records are built once and shared by all rules.
If a table cannot be read or built, the rules that need it are skipped. They do not fail. The format rule for that table reports the problem.
New rules
STR010–015:manifest.json. Its version is supported, its files exist, and their hashes match.FMT020–040: the manifest and each table build into 1.0 records.REC008–028: checks across records. For example, counts, key frames, timestamps and capabilities.REF015–025,REF107–108,REF204–207,REF302–306: links between tables, links to files, and links to the lanelet2 map.Checking hashes reads every file, including videos and rosbags can take a long time, so
STR012is opt-in with--checksum. Without it,STR012gives a warning that hashes were not checked.Changes to existing code
nullas "no link", like""in 0.x.--fixon a 1.0 dataset also updates the table's hash inmanifest.json.Sample dataset fix
REF303andREF304found a bug in the 1.0 sample. Its route and traffic light pointed to map elements that did not exist.The 1.0 sample now has its own map, with a traffic light.
About
record_name()Error messages name the record they are about, for example
SampleAnnotation box1.Rules that check several tables only know the table name, for example
sample_annotation. So their messages looked different from the others.record_name()gets the class name from the 1.0 registry. Now all messages look the same.Tests
Not checked yet
Real 0.x datasets cannot be checked with the 1.0 rules yet. That needs a writer for 1.0 datasets, which comes next.